Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for adding/editing/removing media captions. #3547

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Add support for adding/editing/removing media captions. #3547

merged 3 commits into from
Nov 21, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Nov 21, 2024 •
edited
Loading

Does what it says on the tin. Might add some more tests to this before merging, but we don't have anything around the TimelineItemMenuActionProvider right now.

Closes #3509.

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-11-21.at.16.10.40.mp4

@pixlwave pixlwave requested a review from a team as a code owner November 21, 2024 16:12
@pixlwave pixlwave requested review from Velin92 and removed request for a team November 21, 2024 16:12
@pixlwave pixlwave added the pr-change for updates to an existing feature label Nov 21, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 21, 2024 •
edited
Loading

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against b8f2a1e

@codecov Codecov
Copy link

codecov bot commented Nov 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 25.00000% with 90 lines in your changes missing coverage. Please review.

Project coverage is 78.74%. Comparing base (c081e53) to head (b8f2a1e).
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../Screens/Timeline/TimelineInteractionHandler.swift 0.00% 38 Missing ⚠️
...ne/TimelineController/RoomTimelineController.swift 0.00% 24 Missing ⚠️
...View/ItemMenu/TimelineItemMenuActionProvider.swift 0.00% 9 Missing ⚠️
...eItems/EventBasedMessageTimelineItemProtocol.swift 0.00% 8 Missing ⚠️
...X/Sources/Screens/Timeline/TimelineViewModel.swift 0.00% 7 Missing ⚠️
...imeline/View/ItemMenu/TimelineItemMenuAction.swift 50.00% 4 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3547      +/-   ##
===========================================
- Coverage    78.86%   78.74%   -0.12%     
===========================================
  Files          751      751              
  Lines        63152    63227      +75     
===========================================
- Hits         49802    49788      -14     
- Misses       13350    13439      +89
Flag Coverage Δ
unittests 69.73% <25.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Velin92
Velin92 approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@Velin92 Velin92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pixlwave
Copy link
Member Author

Might add some more tests to this before merging, but we don't have anything around the TimelineItemMenuActionProvider right now.

Change of plan: Going to add captions to file items and support copying captions and then I'll UI test it all.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@pixlwave pixlwave merged commit 7e1476d into develop Nov 21, 2024
11 checks passed
@pixlwave pixlwave deleted the doug/editing-captions branch November 21, 2024 18:18
@pixlwave pixlwave mentioned this pull request Nov 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Velin92 Velin92 Velin92 approved these changes

Assignees
No one assigned
Labels
pr-change for updates to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] Edit a media caption
2 participants
@pixlwave @Velin92